Closed Bug 1674677 Opened 5 years ago Closed 4 years ago

crashreporter.cpp: do not use 'else' after 'return'

Categories

(Toolkit :: Crash Reporting, task)

Product:
Toolkit
Component:
Crash Reporting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: Sylvestre, Assigned: sourav.mukherjee619)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 2 obsolete files)

Bug 1674677 - Adjust the code formatting in the crash reporter client r=gsvelto
47 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1674675 +++

+++ This bug was initially created as a clone of Bug #1674609 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'return'
https://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter.cpp#148-149
and
https://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter.cpp#531-533

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Component: General → Application Update
Product: Core → Toolkit
Component: Application Update → Crash Reporting
Assignee: nobody → sourav.mukherjee619
Status: NEW → ASSIGNED
Attachment #9192921 - Attachment is obsolete: true
Attachment #9192924 - Attachment description: Bug 1674677 returning without else r=gsvelto@mozilla.com → Bug 1674677 returning without else r=gsvelto
Attachment #9192924 - Attachment description: Bug 1674677 returning without else r=gsvelto → Bug 1674677 returning without else r=gsvelto@mozilla.com
Attachment #9192927 - Attachment description: Bug 1674677 clang-format changes r=gsvelto@mozilla.com → Bug 1674677 - Adjust the code formatting in the crash reporter client r=gsvelto
Attachment #9192927 - Attachment is obsolete: true
Attachment #9192924 - Attachment description: Bug 1674677 returning without else r=gsvelto@mozilla.com → Bug 1674677 - Adjust the code formatting in the crash reporter client r=gsvelto
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7da9e8750ee2 Adjust the code formatting in the crash reporter client r=gsvelto

https://hg.mozilla.org/mozilla-central/rev/7da9e8750ee2

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: